Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detail the expected user order #3

Open
wants to merge 10 commits into
base: solutions
Choose a base branch
from

Conversation

lotharschulz
Copy link

With this PR I propose to detail the expected user order for users with same contributions in Aggregation.kt.
To Highlight my point, I adapted the test respectively the expected user list:

  • added Beth (with the same number of contributions as Bob) to the expected user list (1, 2).

The existing aggregate implementation failed with the adapted expected user list in my tests.
However, the test passes with the adapted expected user list with the proposed detailed user order.

Please note: the key selector of fun groupBy recognizes Bob first and Beth afterwards, because Bob is part of the second element of the actual user list. The existing tests would pass in case Beth would be recognized by the key selector prior to Bob (e.g. as part of the first user list element).


Additional change: gradle patch version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants